Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link local react-error-overlay package in kitchensink test #3139

Merged
merged 1 commit into from
Sep 16, 2017

Conversation

tharakawj
Copy link
Contributor

In #2515, we removed react-error-overlay from the dependency list of react-scripts, and now it's only included via react-dev-utils. This causes kitchensink test to download and use published react-error-overlay package from NPM instead of using the local package since replace-own-deps.js can't handle it anymore. As a result, the test fails when there are changes that need sync in the local react-error-overlay and react-dev-utils packages (#3100).

This PR fixes the issue by linking the local package with npm link.

@tharakawj tharakawj merged commit 89bf273 into facebook:master Sep 16, 2017
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants